mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Jonas Fonseca <jonas.fonseca@savoirfairelinux.com>,
	platform-driver-x86 <platform-driver-x86@vger.kernel.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection
Date: Tue, 3 May 2011 07:13:45 -0700	[thread overview]
Message-ID: <20110503141345.GB8056@kroah.com> (raw)
In-Reply-To: <20110503103919.5b0daa5e@lxorguk.ukuu.org.uk>

On Tue, May 03, 2011 at 10:39:19AM +0100, Alan Cox wrote:
> > > I had a look at other drivers, and /sys/devices/platform/ts/ seems to be
> > > a good place to hold those entries (one per options as you suggested).
> > > Do you agree with that?
> > 
> > No, this is not a platform device, is it?  Only platform devices go
> > there, and I really doubt you have many of them for this board.
> 
> It seems analogous to some of the laptop helpers so I don't think it is
> that unreasonable to make the board config a platform device of its own -
> we don't really have a general solution to the board as a device, so if
> you look at equivalents on laptops and the like we have assorted platform
> control interfaces that are platform devices.

Platform control devices are great, I have no objection to that.  I do
object to random proc files to try to describe the fact that this board
has a rs232 port on it, when that is able to be determined elsewhere.

thanks,

greg k-h

  reply	other threads:[~2011-05-03 14:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 22:21 [RFC 0/5] Support for Technologic Systems TS-5500 board Vivien Didelot
2011-04-29 22:21 ` [RFC 1/5] platform-drivers-x86: add support for Technologic Systems TS-5xxx detection Vivien Didelot
2011-04-29 23:32   ` Greg KH
2011-05-02 21:07     ` Vivien Didelot
2011-05-02 21:55       ` Greg KH
2011-05-03  9:39         ` Alan Cox
2011-05-03 14:13           ` Greg KH [this message]
2011-04-30 10:07   ` Alan Cox
2011-05-04 15:15     ` Vivien Didelot
2011-05-04 15:29       ` Alan Cox
2011-05-04 20:34         ` Vivien Didelot
2011-05-05 13:38           ` Alan Cox
2011-05-11 22:24             ` Vivien Didelot
2011-05-17 12:37   ` Sean Young
2011-05-18 15:03     ` Vivien Didelot
2011-04-29 22:21 ` [RFC 2/5] gpio: add support for Technologic Systems TS-5500 GPIOs Vivien Didelot
2011-04-30 10:15   ` Alan Cox
2011-05-13 21:33     ` Vivien Didelot
2011-05-13 22:03       ` Alan Cox
2011-05-04 16:29   ` Arnd Bergmann
2011-04-29 22:21 ` [RFC 3/5] serial: add support for Technologic Systems TS-5500 RS-485 serial port Vivien Didelot
2011-04-30 10:17   ` Alan Cox
2011-06-06 20:48     ` Vivien Didelot
2011-04-29 22:21 ` [RFC 4/5] leds: add support for Technologic Systems TS-5500 leds Vivien Didelot
2011-05-03  6:04   ` Govindraj
2011-04-29 22:21 ` [RFC 5/5] hwmon: add support for Technologic Systems TS-5500 A-D converter Vivien Didelot
2011-04-30  3:39   ` [lm-sensors] " Guenter Roeck
2011-04-30  9:56     ` Jonathan Cameron
2011-05-03 15:55     ` Vivien Didelot
2011-05-03 17:33       ` Guenter Roeck
2011-05-04  9:03       ` Jonathan Cameron
2011-04-30 10:20   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110503141345.GB8056@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jonas.fonseca@savoirfairelinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome