From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754450Ab1ECR6m (ORCPT ); Tue, 3 May 2011 13:58:42 -0400 Received: from kroah.org ([198.145.64.141]:38026 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264Ab1ECR6F (ORCPT ); Tue, 3 May 2011 13:58:05 -0400 Date: Tue, 3 May 2011 10:54:12 -0700 From: Greg KH To: Sutharsan Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, david.cross@cypress.com, srmt@cypress.com Subject: Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros Message-ID: <20110503175412.GA18990@kroah.com> References: <1304016521.3749.13.camel@sutharsan-laptop> <20110428194725.GB25302@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110428194725.GB25302@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 28, 2011 at 12:47:25PM -0700, Greg KH wrote: > On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote: > > >From Sutharsan Ramamoorthy > > > > This patch replaces custom debug macros with Linux kernel's pr_...() macros. > > Why not use the dev_dbg() and other macros instead of these? You do > have access to a struct device for all of these places in the code, > right? As I never got a response from you, I'm dropping this from my patch-queue. Please resend when you have addressed this issue. thanks, greg k-h