From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jamie Iles <jamie@jamieiles.com>
Cc: Anton Vorontsov <cbouatmailru@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
tglx@linutronix.de, arnd@arndb.de, nico@fluxnic.net
Subject: Re: [PATCHv3 0/7] gpio: extend basic_mmio_gpio for different controllers
Date: Wed, 4 May 2011 15:44:40 +0100 [thread overview]
Message-ID: <20110504154440.1674adb9@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110504143757.GB15967@pulham.picochip.com>
> OK, so here's what I've got so far (patches attached). I've updated the
> basic_mmio_gpio library with your initial lkml patch and updated it to
> allow bgpio_chip to be embedded in another structure. I've also
> attempted to convert over the bt8xx and langwell drivers but they're a
> little rough around the edges in places (and untested as I don't have
> the hardware).
Looking at the Langwell driver you replace 130 lines of code that do the
job, with 126 lines of code that do setup for a whole extra module which
makes it bigger and slower as well as much harder to maintain.
That sounds to me like for Langwell at least it is not worth doing
because all you've done is added complexity, indirection and overhead. So
NAK the Langwell one.
The bt8xx looks a nice example of one of the cases where it will help
however.
Alan
next prev parent reply other threads:[~2011-05-04 14:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 11:21 Jamie Iles
2011-04-11 11:21 ` [PATCHv3 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 3/7] basic_mmio_gpio: allow overriding number of gpio Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 4/7] basic_mmio_gpio: request register regions Jamie Iles
2011-05-03 19:41 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-11 12:05 ` Anton Vorontsov
2011-05-03 19:42 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-11 12:06 ` Anton Vorontsov
2011-05-03 19:42 ` Grant Likely
2011-04-11 11:21 ` [PATCHv3 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-05-03 19:42 ` Grant Likely
2011-05-03 21:09 ` [PATCHv3 0/7] gpio: extend basic_mmio_gpio for different controllers Grant Likely
2011-05-03 21:13 ` Grant Likely
2011-05-03 21:36 ` Grant Likely
2011-05-03 21:52 ` Anton Vorontsov
2011-05-03 22:04 ` Jamie Iles
2011-05-03 22:34 ` Anton Vorontsov
2011-05-04 0:00 ` Grant Likely
2011-05-04 10:36 ` Anton Vorontsov
2011-05-04 11:09 ` Jamie Iles
2011-05-04 11:31 ` Anton Vorontsov
2011-05-04 14:37 ` Jamie Iles
2011-05-04 14:43 ` Grant Likely
2011-05-04 14:44 ` Alan Cox [this message]
2011-05-04 14:57 ` Jamie Iles
2011-05-04 15:02 ` Anton Vorontsov
2011-05-04 15:04 ` Jamie Iles
2011-05-13 19:37 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504154440.1674adb9@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=cbouatmailru@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®