From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755455Ab1EEQhR (ORCPT ); Thu, 5 May 2011 12:37:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41192 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755364Ab1EEQhP (ORCPT ); Thu, 5 May 2011 12:37:15 -0400 Date: Thu, 5 May 2011 18:37:08 +0200 From: Jan Kara To: Wu Fengguang Cc: Andrew Morton , Jan Kara , Mel Gorman , Mel Gorman , Dave Chinner , Itaru Kitayama , Minchan Kim , Linux Memory Management List , "linux-fsdevel@vger.kernel.org" , LKML Subject: Re: [PATCH 6/6] writeback: refill b_io iff empty Message-ID: <20110505163708.GN5323@quack.suse.cz> References: <20110420080336.441157866@intel.com> <20110420080918.560499032@intel.com> <20110504073931.GA22675@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110504073931.GA22675@localhost> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04-05-11 15:39:31, Wu Fengguang wrote: > To help understand the behavior change, I wrote the writeback_queue_io > trace event, and found very different patterns between > - vanilla kernel > - this patchset plus the sync livelock fixes > > Basically the vanilla kernel each time pulls a random number of inodes > from b_dirty, while the patched kernel tends to pull a fixed number of > inodes (enqueue=1031) from b_dirty. The new behavior is very interesting... This regularity is really strange. Did you have a chance to look more into it? I find it highly unlikely that there would be exactly 1031 dirty inodes in b_dirty list every time you call move_expired_inodes()... Honza -- Jan Kara SUSE Labs, CR