Re: [RFC 1/2] misc: add Atheros ar1520 GPS support

[Randy Dunlap <rdunlap@xenotime.net>]

On Fri, 6 May 2011 15:09:39 -0700 Luis R. Rodriguez wrote:

> From: Allen Kao <allen.kao@atheros.com>
> 
> This adds support for the Atheros ar1520 GPS device.
> 
> Cc: Roman Gezikov <roman.gezikov@atheros.com>
> Cc: Joonas Viskari <joonas.viskari@atheros.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: x86@kernel.org
> Signed-off-by: Allen Kao <allen.kao@atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>  drivers/misc/Kconfig   |   10 ++
>  drivers/misc/Makefile  |    1 +
>  drivers/misc/ar1520.c  |  406 ++++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/ar1520.h |   49 ++++++
>  4 files changed, 466 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/misc/ar1520.c
>  create mode 100644 include/linux/ar1520.h
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 4e007c6..7108214 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -379,6 +379,16 @@ config HMC6352
>  	  This driver provides support for the Honeywell HMC6352 compass,
>  	  providing configuration and heading data via sysfs.
>  
> +config AR1520
> +	tristate "Atheros AR1520 support"
> +	depends on I2C

Looks like it also depends on GPIOLIB.

> +	help
> +	  If you say yes here you get support for the Atheros
> +	  AR1520 GPS chip.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called ar1520. If unsure, say N here.
> +
>  config EP93XX_PWM
>  	tristate "EP93xx PWM support"
>  	depends on ARCH_EP93XX



+#define AR1520_IOCTL_MAGIC      0xc2

^^^^^ needs to be added to Documentation/ioctl/ioctl-number.txt, please.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***