From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: sangtae.ha@gmail.com, injongrhee@gmail.com,
Valdis.Kletnieks@vt.edu, rdunlap@xenotime.net, lkml@techboom.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tcp_cubic: limit delayed_ack ratio to prevent divide error
Date: Sun, 08 May 2011 15:52:15 -0700 (PDT) [thread overview]
Message-ID: <20110508.155215.242144177.davem@davemloft.net> (raw)
In-Reply-To: <20110504130456.425dee68@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 4 May 2011 13:04:56 -0700
> TCP Cubic keeps a metric that estimates the amount of delayed
> acknowledgements to use in adjusting the window. If an abnormally
> large number of packets are acknowledged at once, then the update
> could wrap and reach zero. This kind of ACK could only
> happen when there was a large window and huge number of
> ACK's were lost.
>
> This patch limits the value of delayed ack ratio. The choice of 32
> is just a conservative value since normally it should be range of
> 1 to 4 packets.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Stephen.
prev parent reply other threads:[~2011-05-08 22:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 16:03 Divide error in bictcp_cong_avoid ? TB
2011-05-04 17:49 ` Randy Dunlap
2011-05-04 18:33 ` Stephen Hemminger
2011-05-04 18:35 ` Randy Dunlap
2011-05-04 19:03 ` TB
2011-05-04 18:56 ` David Miller
2011-05-04 19:31 ` Valdis.Kletnieks
2011-05-04 19:37 ` Stephen Hemminger
2011-05-04 19:40 ` David Miller
2011-05-04 20:01 ` Valdis.Kletnieks
2011-05-04 20:04 ` [PATCH] tcp_cubic: limit delayed_ack ratio to prevent divide error Stephen Hemminger
2011-05-04 20:53 ` Brandeburg, Jesse
2011-05-06 16:15 ` TB
2011-05-06 16:53 ` Stephen Hemminger
2011-05-06 17:39 ` TB
2011-05-11 14:49 ` TB
2011-05-11 15:22 ` Stephen Hemminger
2011-05-11 15:35 ` TB
2011-05-08 22:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508.155215.242144177.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=injongrhee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@techboom.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sangtae.ha@gmail.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome