From: Oleg Nesterov <oleg@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH ptrace] ptrace: fix signal->wait_chldexit usage in task_clear_group_stop_trapping()
Date: Sun, 8 May 2011 17:40:51 +0200 [thread overview]
Message-ID: <20110508154051.GA11251@redhat.com> (raw)
In-Reply-To: <20110508153435.GA11046@redhat.com>
On 05/08, Oleg Nesterov wrote:
>
> Of course, we should take siglock. I meant, we could probably make
>
> static void ptrace_s_stopped_traced(struct task_struct *task)
> {
> bool wait_trap = false;
>
> spin_lock(&task->sighand->siglock);
this needs lock_task_sighand() of course.
And in any case this is minor.
Oleg.
next prev parent reply other threads:[~2011-05-08 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 9:52 Tejun Heo
2011-05-08 13:35 ` Oleg Nesterov
2011-05-08 14:02 ` Tejun Heo
2011-05-08 15:34 ` Oleg Nesterov
2011-05-08 15:40 ` Oleg Nesterov [this message]
2011-05-08 15:55 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110508154051.GA11251@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome