From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] tulip: logging cleanups
Date: Mon, 09 May 2011 11:47:06 -0700 (PDT) [thread overview]
Message-ID: <20110509.114706.189685729.davem@davemloft.net> (raw)
In-Reply-To: <cover.1304733889.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Fri, 6 May 2011 19:08:41 -0700
> Joe Perches (4):
> tulip: xircom_cb: Convert #ifdef DEBUG blocks and enter/leave uses
> tulip: Convert printks to netdev_<level>
> tulip: Convert uses of KERN_DEBUG
> tulip: Use pr_<level> where appropriate
With the advent of the function tracer, those silly function entry/exit
logging things are entirely superfluous.
They make the code look ugly too.
So you have my approval to just kill those things off entirely.
Please do that and respin this patch set, thanks Joe!
next prev parent reply other threads:[~2011-05-09 18:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-07 2:08 Joe Perches
2011-05-07 2:08 ` [PATCH net-next 1/4] tulip: xircom_cb: Convert #ifdef DEBUG blocks and enter/leave uses Joe Perches
2011-05-12 3:36 ` Grant Grundler
2011-05-07 2:08 ` [PATCH net-next 2/4] tulip: Convert printks to netdev_<level> Joe Perches
2011-05-12 4:09 ` Grant Grundler
2011-05-12 4:59 ` Joe Perches
2011-05-14 20:30 ` Grant Grundler
2011-05-07 2:08 ` [PATCH net-next 3/4] tulip: Convert uses of KERN_DEBUG Joe Perches
2011-05-07 2:08 ` [PATCH net-next 4/4] tulip: Use pr_<level> where appropriate Joe Perches
2011-05-09 18:47 ` David Miller [this message]
2011-05-09 19:08 ` [PATCH net-next 5/4] tulip: xircom_cb: Remove useless func_enter and func_exit Joe Perches
2011-05-09 19:10 ` David Miller
2011-05-09 19:17 ` Joe Perches
2011-05-09 19:41 ` David Miller
2011-05-09 19:45 [PATCH net-next 0/4] tulip: logging cleanups Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509.114706.189685729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®