mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: maximilian attems <max@stro.at>
To: Nuno Subtil <subtil@gmail.com>
Cc: Robert Gordon <robert@greenroomsoftware.com>,
	Michal Marek <mmarek@suse.cz>,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] deb-pkg: fix cross-compile build
Date: Tue, 10 May 2011 12:41:23 +0000	[thread overview]
Message-ID: <20110510124123.GE13278@vostochny.stro.at> (raw)
In-Reply-To: <BANLkTimApO4j-Hsvo2OCc=PnEdOhHu76OA@mail.gmail.com>

On Mon, May 09, 2011 at 10:29:22PM -0700, Nuno Subtil wrote:
> It looks like your patch duplicates the arch detection logic that's
> already in create_package, except not completely. I think this is not
> desirable.
> 
> I modified your patch to isolate this logic into a separate function
> and respect the KBUILD_DEBARCH override (which mostly means I moved
> the original logic into a separate function). This should make your
> case work as well, besides respecting the KBUILD_DEBARCH override.
> 
> Maks, Michal, can you please take a look at this new patch?

thanks doing right now.

Michal please hold off until I have time to give it some runs.

-- 
maks


  reply	other threads:[~2011-05-10 12:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04  5:59 Nuno Subtil
2011-05-04 20:48 ` Michal Marek
2011-05-05  9:07   ` maximilian attems
2011-05-05 15:42     ` Robert Gordon
2011-05-05 17:10       ` Nuno Subtil
     [not found]         ` <4DC2EB2B.1050203@greenroomsoftware.com>
2011-05-05 18:34           ` Robert Gordon
2011-05-10  5:29           ` Nuno Subtil
2011-05-10 12:41             ` maximilian attems [this message]
2011-05-12 14:01               ` Robert Gordon
2011-05-12 19:45                 ` Nuno Subtil
2011-05-13  2:50                   ` Robert Gordon
2011-05-10  5:25 Nuno Subtil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510124123.GE13278@vostochny.stro.at \
    --to=max@stro.at \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=robert@greenroomsoftware.com \
    --cc=subtil@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®