From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Joe Perches <joe@perches.com>
Cc: Jiri Kosina <trivial@kernel.org>,
Linux PCMCIA team <linux-pcmcia@lists.infradead.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [TRIVIAL PATCH 0/3] pcmcia: Make struct pcmcia_device_id const
Date: Wed, 11 May 2011 10:51:34 +0200 [thread overview]
Message-ID: <20110511085134.GA27606@comet.dominikbrodowski.net> (raw)
In-Reply-To: <1304705095.11874.21.camel@Joe-Laptop>
On Fri, May 06, 2011 at 11:04:55AM -0700, Joe Perches wrote:
> On Fri, 2011-05-06 at 08:15 +0200, Dominik Brodowski wrote:
> > On Tue, May 03, 2011 at 07:28:59PM -0700, Joe Perches wrote:
> > > Reduces data use.
> > > Staging could be applied now, but additional harmless warnings do result.
> > > Joe Perches (3):
> > > pcmcia: Make declaration and uses of struct pcmcia_device_id const
> > > pcmcia: Convert pcmcia_device_id declarations to const
> > > staging: pcmcia: Convert pcmcia_device_id declarations to const
> > Thanks, applied all three patches to the pcmcia git tree.
>
> Hi Dominik, just so you're aware...
>
> By the time your tree gets pushed, there'll likely
> be conflicts with staging changes.
Well, -next doesn't show any issues so far. *knock on wood*
> There are also a couple of uses of pcmcia_device_id
> in sound/ that could be modified.
>
> $ grep -rPwn --include=*.[ch] pcmcia_device_id sound
> sound/pcmcia/vx/vxpocket.c:353:static struct pcmcia_device_id vxp_ids[] = {
> sound/pcmcia/pdaudiocf/pdaudiocf.c:281:static struct pcmcia_device_id snd_pdacf_ids[] = {
>
> Here's a patch for those as well
Thanks, applied.
Best,
Dominik
prev parent reply other threads:[~2011-05-11 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 2:28 Joe Perches
2011-05-04 2:29 ` [TRIVIAL PATCH 1/3] pcmcia: Make declaration and uses of " Joe Perches
2011-05-04 2:29 ` [TRIVIAL PATCH 2/3] pcmcia: Convert pcmcia_device_id declarations to const Joe Perches
2011-05-04 4:07 ` Kurt Van Dijck
2011-05-04 2:29 ` [TRIVIAL PATCH 3/3] staging: " Joe Perches
2011-05-06 6:15 ` [TRIVIAL PATCH 0/3] pcmcia: Make struct pcmcia_device_id const Dominik Brodowski
2011-05-06 18:04 ` Joe Perches
2011-05-11 8:51 ` Dominik Brodowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110511085134.GA27606@comet.dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®