From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Javier Cardona <javier@cozybit.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related)
Date: Thu, 12 May 2011 14:56:33 +1000 [thread overview]
Message-ID: <20110512145633.69302dd4.sfr@canb.auug.org.au> (raw)
In-Reply-To: <BANLkTik+=yh3eq6Snp9SfC0xn--Deccefw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On Wed, 11 May 2011 21:37:16 -0700 Javier Cardona <javier@cozybit.com> wrote:
>
> Hi Stephen,
>
> On Wed, May 11, 2011 at 9:10 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > Hi John,
> >
> > After merging the final tree, today's linux-next build (i386 defconfig)
> > failed like this:
> >
> > net/mac80211/cfg.c: In function 'sta_apply_parameters':
> > net/mac80211/cfg.c:746: error: 'struct sta_info' has no member named 'plink_state'
>
> Sorry, I just saw this. My apologies. The fixup is valid but I'm
> trying to understand why it is needed.
> ieee80211_vif_is_mesh(&sdata->vif) compiles to 'false' when
> CONFIG_MAC80211_MESH is not defined... wouldn't the compiler remove
> that dead code? (Obviously it did not...)
The compiler will elide that code but only after compiling it, so the
code still has to be correct.
> Anyway, given that this is necessary, it's probably cleaner to extend
> the #ifdef block to the entire body of the outer if as follows:
I think you have the #ifdef one line too low.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-05-12 4:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 4:10 Stephen Rothwell
2011-05-12 4:37 ` Javier Cardona
2011-05-12 4:56 ` Stephen Rothwell [this message]
2011-05-12 17:22 ` Javier Cardona
2011-05-12 23:01 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 5:58 Stephen Rothwell
2011-12-22 8:38 ` Kalle Valo
2011-12-22 16:57 ` Michal Marek
2011-12-23 20:50 ` Michal Marek
2011-12-24 1:29 ` Kalle Valo
2011-12-24 1:26 ` Kalle Valo
2011-08-10 2:21 Stephen Rothwell
2011-08-10 6:11 ` Kalle Valo
2011-02-25 6:16 Stephen Rothwell
2011-02-25 20:33 ` wwguy
2011-02-24 6:24 Stephen Rothwell
2011-02-22 7:15 Stephen Rothwell
2011-02-22 15:45 ` Larry Finger
2011-01-05 4:10 Stephen Rothwell
2010-12-16 3:29 Stephen Rothwell
2010-12-16 4:49 ` Larry Finger
2010-12-07 3:12 Stephen Rothwell
2010-11-17 2:48 Stephen Rothwell
2010-11-17 16:03 ` Randy Dunlap
2010-11-18 2:27 ` Stephen Rothwell
2010-11-18 21:09 ` Gustavo F. Padovan
2010-10-12 5:35 Stephen Rothwell
2010-03-24 4:59 Stephen Rothwell
2010-03-24 8:13 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110512145633.69302dd4.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=javier@cozybit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®