From: Samuel Ortiz <sameo@linux.intel.com>
To: Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@ti.com,
Graeme Gregory <gg@slimlogic.co.uk>,
grant.likely@secretlab.ca
Subject: Re: [PATCHv2 4/5] TPS65911: Add support for added GPIO lines
Date: Fri, 13 May 2011 18:33:05 +0200 [thread overview]
Message-ID: <20110513163304.GJ8970@sortiz-mobl> (raw)
In-Reply-To: <2900D739-7BB3-4553-A485-16FA306146D0@slimlogic.co.uk>
Hi Jorge,
On Wed, May 04, 2011 at 07:21:41PM -0500, Jorge Eduardo Candelaria wrote:
> @@ -76,7 +77,12 @@ void tps65910_gpio_init(struct tps65910 *tps65910, int gpio_base)
> tps65910->gpio.label = tps65910->i2c_client->name;
> tps65910->gpio.dev = tps65910->dev;
> tps65910->gpio.base = gpio_base;
> - tps65910->gpio.ngpio = 1;
> + if (tps65910_chip_id(tps65910) == TPS65910)
> + tps65910->gpio.ngpio = 6;
> + else if (tps65910_chip_id(tps65910) == TPS65911)
> + tps65910->gpio.ngpio = 9;
> + else
> + return;
That should be handled through a switch statement too.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-05-13 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 0:21 Jorge Eduardo Candelaria
2011-05-09 19:39 ` Jorge Eduardo Candelaria
2011-05-13 16:33 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513163304.GJ8970@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=grant.likely@secretlab.ca \
--cc=jedu@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®