From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
linux-kernel@vger.kernel.org, Harald Welte <laforge@gnumonks.org>,
Philipp Zabel <philipp.zabel@gmail.com>,
Paul Parsons <lost.distance@yahoo.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v2 2/3] ASoC: add iPAQ hx4700 machine driver
Date: Mon, 16 May 2011 22:35:51 +0100 [thread overview]
Message-ID: <20110516213551.GB2570@sirena.org.uk> (raw)
In-Reply-To: <1305579805-15617-3-git-send-email-mad_soft@inbox.ru>
On Tue, May 17, 2011 at 01:03:24AM +0400, Dmitry Artamonow wrote:
> AK4641 connected via I2S and I2C, jack detection via GPIO.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
Same thing here - pretty good but a bit out of date.
> + /* Add hx4700 specific widgets */
> + snd_soc_dapm_new_controls(dapm, ak4641_dapm_widgets,
> + ARRAY_SIZE(ak4641_dapm_widgets));
> +
> + /* Set up hx4700 specific audio path interconnects */
> + snd_soc_dapm_add_routes(dapm, audio_map, ARRAY_SIZE(audio_map));
> +
> + snd_soc_dapm_sync(dapm);
Data based init for these too please.
> +static int __init hx4700_init(void)
> +{
> + int ret;
> +
> + if (!machine_is_h4700())
> + return -ENODEV;
> +
> + ret = gpio_request(GPIO107_HX4700_SPK_nSD, "SPK_POWER");
> + if (ret)
> + goto err_request_spk;
> + ret = gpio_request(GPIO92_HX4700_HP_DRIVER, "EP_POWER");
> + if (ret)
> + goto err_request_ep;
> +
> + gpio_direction_output(GPIO107_HX4700_SPK_nSD, 1);
> + gpio_direction_output(GPIO92_HX4700_HP_DRIVER, 0);
> +
> + hx4700_snd_device = platform_device_alloc("soc-audio", -1);
> + if (!hx4700_snd_device) {
Use a regular platform device to register the machine and call
snd_soc_register_card() to instantiate please.
next prev parent reply other threads:[~2011-05-16 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 21:03 [PATCH v2 0/3] ASoC: add support for audio on iPaq hx4700 Dmitry Artamonow
2011-05-16 21:03 ` [PATCH v2 1/3] ASoC: Asahi Kasei AK4641 codec driver Dmitry Artamonow
2011-05-16 21:25 ` [alsa-devel] " Mark Brown
2011-05-17 4:26 ` Dmitry Artamonow
2011-05-16 21:03 ` [PATCH v2 2/3] ASoC: add iPAQ hx4700 machine driver Dmitry Artamonow
2011-05-16 21:35 ` Mark Brown [this message]
2011-05-16 21:03 ` [PATCH v2 3/3] pxa/hx4700: add I2C board info for AK4641 codec Dmitry Artamonow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516213551.GB2570@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=eric.y.miao@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lost.distance@yahoo.com \
--cc=lrg@slimlogic.co.uk \
--cc=mad_soft@inbox.ru \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®