From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932109Ab1ERWBk (ORCPT ); Wed, 18 May 2011 18:01:40 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:42055 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755189Ab1ERWBi (ORCPT ); Wed, 18 May 2011 18:01:38 -0400 Date: Wed, 18 May 2011 18:01:23 -0400 (EDT) Message-Id: <20110518.180123.953614008385558805.davem@davemloft.net> To: decot@google.com Cc: joe@perches.com, szymon@janc.net.pl, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-net-upstream@google.com, snanda@google.com Subject: Re: [PATCH 2/2] forcedeth: allow to silence tx_timeout debug messages From: David Miller In-Reply-To: References: <1305753000-14933-2-git-send-email-decot@google.com> <20110518.171603.2048423328863525352.davem@davemloft.net> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Wed, 18 May 2011 15:01:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Decotigny Date: Wed, 18 May 2011 14:43:58 -0700 > On Wed, May 18, 2011 at 2:16 PM, David Miller wrote: >> You can add a knob which when enabled gives the old verbosity >> back for diagnostic purposes. > > That was the intent of this patch: it adds a debug_tx_timeout module > parameter to act as the knob. I can rephrase the description of the > patch, it didn't make this so clear. > Or are you suggesting I should implement this with another kind of knob? I'm saying implement things differently. Reduce the verbosity of the TX timeout message but still print some amount of information, but provide a new knob that turns on the existing verbose messages.