mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: denzzzhome@yahoo.com
Cc: info@mocean-labs.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net: ks8842 Fix crash on received packet when in PIO mode.
Date: Wed, 18 May 2011 18:03:04 -0400 (EDT)	[thread overview]
Message-ID: <20110518.180304.1707025648201926668.davem@davemloft.net> (raw)
In-Reply-To: <2062.44194.qm@web120510.mail.ne1.yahoo.com>

From: Dennis Aberilla <denzzzhome@yahoo.com>
Date: Wed, 18 May 2011 14:51:14 -0700 (PDT)

> diff --git a/drivers/net/ks8842.c b/drivers/net/ks8842.c
> index f0d8346..9069aee 100644
> --- a/drivers/net/ks8842.c
> +++ b/drivers/net/ks8842.c
> @@ -662,7 +662,7 @@ static void ks8842_rx_frame(struct net_device *netdev,
> 
>    /* check the status */
>    if ((status & RXSR_VALID) && !(status & RXSR_ERROR)) {
> -     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len);
> +     struct sk_buff *skb = netdev_alloc_skb_ip_align(netdev, len + 2);

Your patch has been corrupted by your email client, it has turned TAB
characters into spaces, amongst other things.  This makes your patch
unusable.

Please read Documentation/email-clients.txt, and use that information
to fix your email client, and then send the patch as a test email
to yourself and make sure that you can extract the patch and apply
it cleanly before you resend it here.

Thanks.

  reply	other threads:[~2011-05-18 22:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18 21:51 Dennis Aberilla
2011-05-18 22:03 ` David Miller [this message]
2011-05-18 22:03   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518.180304.1707025648201926668.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=denzzzhome@yahoo.com \
    --cc=info@mocean-labs.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®