mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>,
	LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Yong Zhang <yong.zhang0@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sched: avoid overpull when pulling RT task
Date: Tue, 17 May 2011 21:21:14 -0400	[thread overview]
Message-ID: <20110518012114.GB23940@home.goodmis.org> (raw)
In-Reply-To: <BANLkTi=0pe8U6TZsQcXssV3iK_5Y+jRWCA@mail.gmail.com>

On Tue, May 17, 2011 at 10:25:54PM +0800, Hillf Danton wrote:
> 
> Efforts are put on the puller's side, but bad result is reached:(
> 
> Another patch is prepared, in which pusher is asked to do the hard works,
> say pushees and tasks are selected.
> 
> Unlike puller who only concerns one runqueue that accepts the pulled tasks,
> pusher delivers tasks to more runqueues, so the overpull could get bigger.
> 
> Please review again, thanks.
> 

Have you actually observed an overpull? And if so, how bad was it?

I hate to be fixing bugs that don't really exist.

-- Steve


      parent reply	other threads:[~2011-05-18  1:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-15  4:35 Hillf Danton
2011-05-15  6:35 ` Mike Galbraith
2011-05-15 11:18   ` Hillf Danton
2011-05-16 13:14   ` Hillf Danton
2011-05-16 14:11     ` Mike Galbraith
2011-05-17 14:25       ` Hillf Danton
2011-05-17 18:50         ` Mike Galbraith
2011-05-18  1:21         ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518012114.GB23940@home.goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=dhillf@gmail.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®