From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options
Date: Wed, 18 May 2011 07:16:45 +0200 [thread overview]
Message-ID: <20110518051645.GB15292@game.jcrosoft.org> (raw)
In-Reply-To: <20110517195310.GA17003@merkur.ravnborg.org>
On 21:53 Tue 17 May , Sam Ravnborg wrote:
> On Tue, May 17, 2011 at 05:35:32PM +0200, Michal Marek wrote:
> > For strings and integers, the config_is_xxx macros are useless and
> > sometimes misleading:
> >
> > #define CONFIG_INITRAMFS_SOURCE ""
> > #define config_is_initramfs_source() 1
>
> I'm late with this comment....
> Could we introduce "config_is_foo" using a syntax that
> does not break grepability?
>
> Maybe a syntax like this?
>
> #ifdef CONFIG_FOO
>
> and
>
> if (KCONFIG_FOO())
>
> Grepping for the use of a symbol is a very typical thing,
> so we should try to keep this.
> And with the suggested syntax above I expect fixdep to
> catch up both usage types.
I'll prefer kconfig_foo()
not uppercase
but if we use KCONFIG_FOO no need to touch fixdep
Best Regards,
J.
next prev parent reply other threads:[~2011-05-18 5:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 15:35 Michal Marek
2011-05-17 18:05 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-17 19:44 ` Michal Marek
2011-05-17 19:53 ` Sam Ravnborg
2011-05-18 5:16 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-05-18 6:19 ` Sam Ravnborg
2011-05-18 6:27 ` Arnaud Lacombe
2011-05-18 6:23 ` Arnaud Lacombe
2011-07-13 13:22 ` Michal Marek
2011-07-13 15:20 ` Arnaud Lacombe
2011-07-13 20:08 ` Sam Ravnborg
2011-07-19 13:45 ` Michal Marek
2011-07-25 22:58 ` [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() Michal Marek
2011-07-25 22:58 ` [RFC][PATCH 2/2] mm: Switch NUMA_BUILD and COMPACTION_BUILD to new KCONFIG() syntax Michal Marek
2011-07-26 15:19 ` Michal Hocko
2011-07-26 18:34 ` Michal Marek
2011-07-26 18:52 ` Michal Hocko
2011-07-26 13:01 ` [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() Américo Wang
2011-07-26 13:21 ` Michal Marek
2011-07-26 15:04 ` Randy Dunlap
2011-07-26 18:28 ` Michal Marek
2011-07-26 18:28 ` Randy Dunlap
2011-07-26 18:48 ` Arnaud Lacombe
2011-07-27 0:42 ` Arnaud Lacombe
2011-07-27 4:35 ` Randy Dunlap
2011-07-27 8:36 ` Michal Marek
2011-07-27 13:31 ` Arnaud Lacombe
2011-07-27 13:38 ` Michal Marek
2011-07-27 15:11 ` Arnaud Lacombe
2011-07-27 15:18 ` Michal Marek
2011-07-27 16:36 ` Américo Wang
2011-07-27 15:09 ` Arnaud Lacombe
2011-07-27 15:16 ` Michal Marek
2011-07-27 15:18 ` Arnaud Lacombe
2011-07-29 13:51 ` [PATCH] kconfig: Introduce IS_ENABLED(), IS_BUILTIN() and IS_MODULE() Michal Marek
2011-07-29 17:43 ` Arnaud Lacombe
2011-07-29 18:25 ` Randy Dunlap
2011-07-29 18:58 ` Arnaud Lacombe
2011-08-02 17:33 ` Sam Ravnborg
2011-08-02 17:50 ` Arnaud Lacombe
2011-08-02 19:26 ` Sam Ravnborg
2011-08-02 19:33 ` Michal Marek
2011-08-02 19:33 ` Arnaud Lacombe
2011-05-25 13:35 ` [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518051645.GB15292@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®