From: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
To: Greg KH <greg@kroah.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Olaf Hartmann <o.hartmann@telovital.com>
Subject: Re: [RFC/RFT PATCH] Staging: et131x: add suspend/resume support
Date: Wed, 18 May 2011 13:03:17 -0300 [thread overview]
Message-ID: <20110518160316.GA3502@herton-IdeaPad-Y430> (raw)
In-Reply-To: <20110518152428.GA8106@kroah.com>
On Wed, May 18, 2011 at 08:24:28AM -0700, Greg KH wrote:
> On Wed, May 18, 2011 at 10:17:47AM -0300, Herton Ronaldo Krzesinski wrote:
> > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
>
> I think we need a bit more comments here.
>
> Like have you tested this to verify that it works? Anything else?
An user complained about lack of suspend/resume support, so I did the
patch, it's working accordingly to him from what I could get
(unfortunately I can't test myself, don't have the hardware). I want
others to test too, before this can be pushed (RFT on subject). The bug
report I got: http://bugs.launchpad.net/bugs/766549
But good luck in parsing that... I also want others with same
hardware testing this, to confirm it is ok.
May be this isn't important at this stage, the driver may need another
important things done before...
>
> thanks,
>
> greg k-h
>
--
[]'s
Herton
next prev parent reply other threads:[~2011-05-18 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 13:17 Herton Ronaldo Krzesinski
2011-05-18 15:24 ` Greg KH
2011-05-18 16:03 ` Herton Ronaldo Krzesinski [this message]
2011-05-18 16:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518160316.GA3502@herton-IdeaPad-Y430 \
--to=herton.krzesinski@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.hartmann@telovital.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome