From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tony Luck <tony.luck@gmail.com>, Jens Axboe <jaxboe@fusionio.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: New boot time message: detected capacity change
Date: Thu, 19 May 2011 07:29:03 +0200 [thread overview]
Message-ID: <20110519052903.GA2904@mtj.dyndns.org> (raw)
In-Reply-To: <BANLkTimY+y3vXa0R7Evs6dYLVjJ==KVq1A@mail.gmail.com>
Hello, Linus.
On Wed, May 18, 2011 at 01:50:19PM -0700, Linus Torvalds wrote:
> As it was, I feel that those commit descriptions were actively
> misleading me into thinking this was a regression.
The commit message is incomplete rather than misleading. The problem
has been there for a long time but hasn't affected cdrom so not many
people have noticed it. The changes to media revalidation exposed the
bug for cdrom too, so it became a regression for 2.6.38. Please refer
to the following thread.
https://lkml.org/lkml/2011/3/31/436
As the root cause was the same as the 2009 bug, I just referenced that
one. I should have included the link to the newer thread or explained
how it affected recent conversion from ->media_changed to
->check_events. My bad.
> Maybe it won't cause any problems, but -rc7 is not the time to make
> these kinds of experiments!
The patch was posted Apr 6th. It somehow took quite long to reach
your tree. Sorry about that too.
As for the warning message, I think it wouldn't be harmful but at -rc7
I'm a bit nervous too. I'll take a deeper look.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-05-19 5:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 20:32 Tony Luck
2011-05-18 20:50 ` Linus Torvalds
2011-05-19 5:29 ` Tejun Heo [this message]
2011-05-19 6:01 ` Tejun Heo
2011-05-19 7:27 ` Jens Axboe
2011-05-19 7:25 ` Jens Axboe
2011-05-19 9:30 ` Tejun Heo
2011-05-19 17:39 ` Tony Luck
2011-05-23 11:24 ` [PATCH] block: move bd_set_size() above rescan_partitions() in __blkdev_get() Tejun Heo
2011-05-23 15:51 ` Linus Torvalds
2011-05-23 16:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519052903.GA2904@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®