From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934129Ab1ESSZn (ORCPT ); Thu, 19 May 2011 14:25:43 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:33665 "EHLO out2.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933941Ab1ESSZk (ORCPT ); Thu, 19 May 2011 14:25:40 -0400 X-Sasl-enc: zNI31FcSpn3d1fiNt/u4OMC8hjYYzO8oeiEUD2EWqF0b 1305829539 X-Mailbox-Line: From gregkh@clark.kroah.org Thu May 19 11:24:37 2011 Message-Id: <20110519182437.003013139@clark.kroah.org> User-Agent: quilt/0.48-16.4 Date: Thu, 19 May 2011 11:23:37 -0700 From: Greg KH To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: stable-review@kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Oliver Hartkopp , Alan Cox , "David S. Miller" Subject: [07/21] NET: slip, fix ldisc->open retval In-Reply-To: <20110519182446.GA23751@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2.6.32-longterm review patch. If anyone has any objections, please let us know. ------------------ From: Matvejchikov Ilya commit 057bef938896e6266ae24ec4266d24792d27c29a upstream. TTY layer expects 0 if the ldisc->open operation succeeded. Signed-off-by : Matvejchikov Ilya Acked-by: Oliver Hartkopp Acked-by: Alan Cox Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/slip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/net/slip.c +++ b/drivers/net/slip.c @@ -850,7 +850,9 @@ static int slip_open(struct tty_struct * /* Done. We have linked the TTY line to a channel. */ rtnl_unlock(); tty->receive_room = 65536; /* We don't flow control */ - return sl->dev->base_addr; + + /* TTY layer expects 0 on success */ + return 0; err_free_bufs: sl_free_bufs(sl);