mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] x86: UV uv_tlb.c cleanup
Date: Sat, 21 May 2011 12:38:47 +0200	[thread overview]
Message-ID: <20110521103847.GA26447@elte.hu> (raw)
In-Reply-To: <E1QNVdB-0008Mk-GP@eag09.americas.sgi.com>


* Cliff Wickman <cpw@sgi.com> wrote:

> One logic difference:
> Breaking uv_init_per_cpu() into get_cpu_topology() and summarize_uvhub_sockets()
> actually corrects a possible bug for the theoretical case in which there is a
> missing socket on a blade. An 'smaster' (socket master) had been expected for
> every socket.

Please, as i asked in the previous mail, do not add logic changes to the 
cleanup patch! Please keep it in a separate patch, after the big cleanup patch.

It will be very hard to debug if you find a regression in that cleanup patch: 
since it also changes logic you do not know whether it's due to changed logic 
or one of the cleanups having an unintended side-effect ...

Thanks,

	Ingo

  reply	other threads:[~2011-05-21 10:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-20 19:45 Cliff Wickman
2011-05-21 10:38 ` Ingo Molnar [this message]
2011-05-23 11:41   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110521103847.GA26447@elte.hu \
    --to=mingo@elte.hu \
    --cc=cpw@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®