From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755762Ab1EXJml (ORCPT ); Tue, 24 May 2011 05:42:41 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:56790 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752963Ab1EXJmj (ORCPT ); Tue, 24 May 2011 05:42:39 -0400 Date: Tue, 24 May 2011 10:44:04 +0100 From: Alan Cox To: "Arend van Spriel" Cc: "Andrew Morton" , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "John W. Linville" , "Dan Carpenter" Subject: Re: [RFC] lib: crc8: add new library module providing crc8 algorithm Message-ID: <20110524104404.336c765f@lxorguk.ukuu.org.uk> In-Reply-To: <4DDB622B.1050005@broadcom.com> References: <1306010973-5625-1-git-send-email-arend@broadcom.com> <20110522122325.108b1c86@lxorguk.ukuu.org.uk> <4DD905CC.8040407@broadcom.com> <20110522151959.7fd6e87e@lxorguk.ukuu.org.uk> <4DDB622B.1050005@broadcom.com> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 May 2011 09:45:47 +0200 "Arend van Spriel" wrote: > On 05/22/2011 04:19 PM, Alan Cox wrote: > > Is it just used for wireless in this form ? > > > > See the n_gsm and bluetooth code for what I think is the same crc > > algorithm but in reverse bit order . > > Hi Alan, > > Look into the code in n_gsm and bluetooth code. The algorithm is the > same, but except for the bit order it also is using a different > polynomial. My current implementation has a fixed table. I could do the > table generation runtime with the polynomial and the bit order as > parameters. That would make it more general purpose. Probably not worth it - its so tiny a piece of code anyway (< 500 bytes or so) that it's going to be bigger not smaller if you do that !