mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: Cliff Wickman <cpw@sgi.com>,
	linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v5] x86: UV uv_tlb.c cleanup
Date: Tue, 24 May 2011 21:29:49 +0200	[thread overview]
Message-ID: <20110524192949.GH6561@elte.hu> (raw)
In-Reply-To: <BANLkTiknsRgnkM=pQhAzFDe_uCWG-Du7hw@mail.gmail.com>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Tue, May 24, 2011 at 6:19 PM, Ingo Molnar <mingo@elte.hu> wrote:
> > Don't the kfree()s get changed - i.e. the patch has a side-effect?
> >
> > And yes, while this might be a kmem leak fix, it is a fix and a *SIDE EFFECT*
> > which i explicitly asked to be queued in a separate patch(es) from the large
> > cleanup patch ...
> >
> > The cleanup patch should be a cleanup of existing code - even if that code has
> > bugs. Nothing more. Bug fixes are for different patches.
> 
> There's also renames in the patch that make it pretty hard to review
> for correctness. Formatting changes are best done as separate patches.

Well, yeah, but there were so many cleanliness problems with that code that i 
think we are better off with having this big cleanup over and then start 
working with small, self-contained cleanups and improvements.

Thanks,

	Ingo

  reply	other threads:[~2011-05-24 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-24 13:35 Cliff Wickman
2011-05-24 15:19 ` Ingo Molnar
2011-05-24 15:37   ` Pekka Enberg
2011-05-24 19:29     ` Ingo Molnar [this message]
2011-05-24 19:49       ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110524192949.GH6561@elte.hu \
    --to=mingo@elte.hu \
    --cc=cpw@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®