mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Tanya Brokhman <tlinder@codeaurora.org>
Cc: balbi@ti.com, "'Alan Stern'" <stern@rowland.harvard.edu>,
	"'Sarah Sharp'" <sarah.a.sharp@linux.intel.com>,
	greg@kroah.com, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, ablay@codeaurora.org,
	"'open list'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd
Date: Wed, 25 May 2011 12:49:03 +0300	[thread overview]
Message-ID: <20110525094902.GM14556@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <018e01cc1ac0$2b09b040$811d10c0$@org>

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

Hi,

On Wed, May 25, 2011 at 12:43:10PM +0300, Tanya Brokhman wrote:
> > > But that's why we added the feature flag. Isn't leaving it FALSE the
> > > same as removing the part that updates gadget speed? It is protected
> > with #ifdef.
> > 
> > you mean the module parameter ? This will mean that users will have to
> > remember another module parameter otherwise it will not work in some
> > situations :-)
> > 
> > the module should work without that parameter :-)
> > 
> 
> No, I'm afraid we're talking about different things here. 
> As far as dummy_hcd is concerned:
> Dummy_hcd has a new module parameter that should be set to true if the
> developer wishes the gadget driver to be connected to a SS root hub. Since
> at the moment most of the gadget drivers woun't work at SS connection (lack
> of SS descriptors) the default of this parameter is true and thus the
> connected gadget driver will be enumerated over a HS root hub. Users don't
> have to remember t set anything in order to be able to work with dummy_hcd
> and the existing gadget drivers just as they did up until now.
> 
> We did add a new feature flag (CONFIG_USB_GADGET_SUPERSPEED) that is set
> during compilation. If that flag is defined, then (and only then!) will the
> driver->speed be set to SS by composite_bind. Please keep in mind the

and that's the only thing I'm asking you to remove :-)

we should be to compile dummy_hcd in SuperSpeed and still have
high-speed gadget drivers :-)

> following:
> 1. if CONFIG_USB_GADGET_SUPERSPEED=true, existing gadget drivers are still
> functional with dummy_hcd since as I already mentioned, they will be
> enumerated through HS root hub and thus the gadget.speed will be set to HS.
> This is true for all gadget drivers, including the once that don't define SS
> descriptors.

only due the module parameter, right ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-05-25  9:49 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1306132882-9668-1-git-send-email-tlinder@codeaurora.org>
2011-05-23  6:41 ` [PATCH/RESEND v12 1/8] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-05-23  6:41 ` [PATCH v12 2/8] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-05-23  6:41 ` [PATCH/RESEND v12 3/8] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
2011-05-23  6:41 ` [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-23 12:31   ` Sebastian Andrzej Siewior
2011-05-23 22:18     ` Mike Frysinger
2011-05-24  5:10     ` Tanya Brokhman
2011-05-24  5:14       ` Mike Frysinger
2011-05-24  5:37         ` Tanya Brokhman
2011-05-24 17:12           ` Mike Frysinger
2011-05-23  6:41 ` [PATCH/RESEND v12 5/8] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-05-23  6:41 ` [PATCH v12 6/8] usb:dummy_hcd: use the shared_hcd infrastructure Tatyana Brokhman
2011-05-23  6:41 ` [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
2011-05-23  7:05   ` Felipe Balbi
2011-05-23  7:20     ` Tanya Brokhman
2011-05-23  7:21       ` Felipe Balbi
2011-05-23  8:18         ` Tanya Brokhman
2011-05-23  8:32           ` Felipe Balbi
2011-05-23  9:16             ` Tanya Brokhman
2011-05-23 14:22               ` Alan Stern
2011-05-23 16:08               ` Sarah Sharp
2011-05-23 16:28                 ` Alan Stern
2011-05-23 21:06                   ` Felipe Balbi
2011-05-23 21:21                     ` Alan Stern
2011-05-24  5:53                       ` Tanya Brokhman
2011-05-24 10:18                         ` Felipe Balbi
2011-05-24 10:31                           ` Tanya Brokhman
2011-05-24 10:33                             ` Felipe Balbi
2011-05-24 10:43                               ` Tanya Brokhman
2011-05-24 14:20                                 ` Alan Stern
2011-05-25  4:46                                   ` Tanya Brokhman
2011-05-25  9:21                                     ` Felipe Balbi
2011-05-25  9:26                                       ` Tanya Brokhman
2011-05-25  9:27                                         ` Felipe Balbi
2011-05-25  9:43                                           ` Tanya Brokhman
2011-05-25  9:49                                             ` Felipe Balbi [this message]
2011-05-25 10:03                                               ` Tanya Brokhman
2011-05-25 10:29                                                 ` Felipe Balbi
2011-05-25 10:52                                                   ` Tanya Brokhman
2011-05-25 11:23                                                     ` Felipe Balbi
2011-05-25 11:33                                                       ` Tanya Brokhman
2011-05-25 12:42                                                         ` Felipe Balbi
2011-05-25 14:23                                                         ` Alan Stern
2011-05-25 14:39                                                           ` Alan Stern
2011-05-28 11:05                                                             ` Tanya Brokhman
2011-05-28 14:15                                                               ` Alan Stern
2011-06-07 10:33                                                             ` Felipe Balbi
2011-05-25 17:07                                                           ` Brokhman Tatyana
2011-05-25 17:29                                                             ` Alan Stern
2011-05-25 18:13                                                               ` Brokhman Tatyana
2011-05-25 18:59                                                                 ` Alan Stern
2011-05-26  6:51                                                                   ` Tanya Brokhman
2011-05-26 14:31                                                                     ` Alan Stern
2011-05-26 16:15                                                                       ` Brokhman Tatyana
2011-05-25  9:20                                   ` Felipe Balbi
2011-05-23 15:55             ` Sarah Sharp
2011-05-23 14:20         ` Alan Stern
2011-05-23 14:18     ` Alan Stern
2011-05-23  6:41 ` [PATCH v12 8/8] usb:gadget: coding style fixes Tatyana Brokhman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110525094902.GM14556@legolas.emea.dhcp.ti.com \
    --to=balbi@ti.com \
    --cc=ablay@codeaurora.org \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tlinder@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®