From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Tomoya <tomoya-linux@dsn.okisemi.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
linux-kernel@vger.kernel.org, qi.wang@intel.com,
yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com
Subject: Re: pch_gpio: Support new device ML7223
Date: Wed, 25 May 2011 14:09:46 +0200 [thread overview]
Message-ID: <201105251409.47309.alexander.stein@systec-electronic.com> (raw)
In-Reply-To: <1304938729-10609-1-git-send-email-tomoya-linux@dsn.okisemi.com>
Hello Tomoya,
On Monday 09 May 2011 12:58:49 Tomoya wrote:
> diff --git a/drivers/gpio/pch_gpio.c b/drivers/gpio/pch_gpio.c
> index f970a5f..36919e7 100644
> --- a/drivers/gpio/pch_gpio.c
> +++ b/drivers/gpio/pch_gpio.c
> @@ -283,8 +283,10 @@ static int pch_gpio_resume(struct pci_dev *pdev)
> #define pch_gpio_resume NULL
> #endif
>
> +#define PCI_VENDOR_ID_ROHM 0x10DB
Should this be moved to pci_ids.h?
> static DEFINE_PCI_DEVICE_TABLE(pch_gpio_pcidev_id) = {
> { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x8803) },
> + { PCI_DEVICE(PCI_VENDOR_ID_ROHM, 0x8014) },
Likewise for the product ID. While at it, the ID for EG20T could also be moved
in a separate patch.
> { 0, }
> };
> MODULE_DEVICE_TABLE(pci, pch_gpio_pcidev_id);
Regards,
Alexander
next prev parent reply other threads:[~2011-05-25 12:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 10:58 [PATCH] " Tomoya MORINAGA
2011-05-25 12:09 ` Alexander Stein [this message]
2011-05-26 1:24 ` Tomoya MORINAGA
2011-05-26 6:09 ` Alexander Stein
2011-05-26 7:41 ` Tomoya MORINAGA
2011-05-27 6:58 ` Grant Likely
2011-05-27 7:09 ` [PATCH] " Grant Likely
2011-05-27 8:07 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201105251409.47309.alexander.stein@systec-electronic.com \
--to=alexander.stein@systec-electronic.com \
--cc=grant.likely@secretlab.ca \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.okisemi.com \
--cc=toshiharu-linux@dsn.okisemi.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®