From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
linux-kernel@vger.kernel.org, arnd@arndb.de,
kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/4] Samsung: Move Samsung SoCs GPIO drivers to drivers/gpio
Date: Thu, 26 May 2011 21:22:43 -0600 [thread overview]
Message-ID: <20110527032243.GJ5032@ponder.secretlab.ca> (raw)
In-Reply-To: <20110521112102.GA11887@sirena.org.uk>
On Sat, May 21, 2011 at 12:21:02PM +0100, Mark Brown wrote:
> On Fri, May 20, 2011 at 12:31:28AM -0600, Grant Likely wrote:
> > On Fri, May 20, 2011 at 02:44:41PM +0900, Kyungmin Park wrote:
> > > .../gpiolib.c => drivers/gpio/s5pc100-gpio.c | 0
> > > .../gpiolib.c => drivers/gpio/s5pv210-gpio.c | 0
> > > .../gpiolib.c => drivers/gpio/samsung-gpiolib.c | 3 +-
>
> > drivers/gpio/gpio-*.c please. I'm starting to enforce some level of
> > naming convention.
>
> Hrm, looking at the current mainline drivers the existing tendency seems
> to be mostly towards gpio/*-gpio.c...
However, drivers/i2c/busses is nicely organized with i2c-*.c, and a
lot of the spi drivers are drivers/spi/spi* (although it is a mixed
bag here). I also personally prefer the drivers to have the type as
a prefix instead of a suffix, and I hope to reorganize both
drivers/spi and drivers/gpio to follow the i2c lead in the next
cycle.
True, this does come down to personal taste, but unless someone has a
really strong objection to it then I'll keep asking for new drivers to
use gpio- as a prefix.
g.
next prev parent reply other threads:[~2011-05-27 3:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 5:44 Kyungmin Park
2011-05-20 6:31 ` Grant Likely
2011-05-21 11:21 ` Mark Brown
2011-05-27 3:22 ` Grant Likely [this message]
2011-05-27 5:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527032243.GJ5032@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kgene.kim@samsung.com \
--cc=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®