From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: linux-kernel@vger.kernel.org, paulus@samba.org, hpa@zytor.com,
mingo@redhat.com, eranian@google.com, tzanussi@gmail.com,
penberg@cs.helsinki.fi, torvalds@linux-foundation.org,
efault@gmx.de, peterz@infradead.org, davej@redhat.com,
davem@davemloft.net, fweisbec@gmail.com, kees.cook@canonical.com,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/urgent] perf symbols: Handle /proc/sys/kernel/kptr_restrict
Date: Fri, 27 May 2011 10:38:21 +0200 [thread overview]
Message-ID: <20110527083821.GB21386@elte.hu> (raw)
In-Reply-To: <20110526212040.GA30593@ghostprotocols.net>
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> > Had you done this you'd have immediately noticed that the individual
> > lines are *way* too large to fit on even large terminals. Please
> > break such messages in a much shorter fashion - we want the error
> > messages we output to be readable even on relatively small (80col)
> > terminals.
>
> But it would reflow, no?
Not on all terminals. For example my terminal will just cut anything
beyond the col limit:
# perf report --stdio
No kallsyms or vmlinux with build-id 122214021a666675f6e5ff97d70a85ce7139c0e7 was found
[kernel.kallsyms] with build id 122214021a666675f6e5ff97d70a85ce7139c0e7 not found, continuing without s
Kernel address maps (/proc/{kallsyms,modules}) were restricted, check /proc/sys/kernel/kptr_restrict bef
So we generally want to generate error messages to look good on col80
- it should not be hard here, right?
Thanks,
Ingo
next prev parent reply other threads:[~2011-05-27 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 19:21 tip-bot for Arnaldo Carvalho de Melo
2011-05-26 19:39 ` Ingo Molnar
2011-05-26 21:20 ` Arnaldo Carvalho de Melo
2011-05-27 8:38 ` Ingo Molnar [this message]
2011-05-26 21:28 ` Arnaldo Carvalho de Melo
2011-05-27 8:35 ` Ingo Molnar
2011-05-27 15:46 ` Linus Torvalds
2011-05-27 15:57 ` Arnaldo Carvalho de Melo
2011-05-26 21:30 ` Arnaldo Carvalho de Melo
2011-05-27 8:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527083821.GB21386@elte.hu \
--to=mingo@elte.hu \
--cc=acme@redhat.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®