From: David Miller <davem@davemloft.net>
To: tj@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: blkdev_get() change causes OOPS...
Date: Tue, 31 May 2011 13:13:52 -0700 (PDT) [thread overview]
Message-ID: <20110531.131352.297345785.davem@davemloft.net> (raw)
In-Reply-To: <20110531153744.GB9048@mtj.dyndns.org>
From: Tejun Heo <tj@kernel.org>
Date: Wed, 1 Jun 2011 00:37:44 +0900
> On Mon, May 30, 2011 at 10:35:07PM -0700, David Miller wrote:
>>
>> I don't think whole->bd_disk is guaranteed to be non-NULL where you're
>> dereferencing it in blkdev_get() after commit
>> d4dc210f69bcb0b4bef5a83b1c323817be89bad1 ("block: don't block events
>> on excl write for non-optical devices")
>
> Ah... right, it's there if open succeeded. I should have put the test
> after !res test. Does the following patch fix the problem?
Works here:
Acked-by: David S. Miller <davem@davemloft.net>
Make sure this fix propagates into the stable submission.
prev parent reply other threads:[~2011-05-31 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 5:35 David Miller
2011-05-31 15:37 ` Tejun Heo
2011-05-31 20:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531.131352.297345785.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®