Re: [PATCH] drm/i915: fix regression after clock gating init split

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Sat, 28 May 2011 14:26:48 +1000
Jason Stubbs <jasonbstubbs@gmail.com> wrote:

> From: Jason Stubbs <jasonbstubbs@gmail.com>
> 
> During the refactoring in revision 6067aaeadb5b3df26f27ac827256b1ef01e674f5,
> the intel_enable_clock_gating was split up into several functions that are
> then called indirectly. However, which function to call was not specified for
> the IS_PINEVIEW() case. This patch specifies the correct gating function.
> 
> Signed-off-by: Jason Stubbs <jasonbstubbs@gmail.com>
> ---
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index f553ddf..bb1b59b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -7675,6 +7675,7 @@ static void intel_init_display(struct drm_device *dev)
>  			dev_priv->display.update_wm = NULL;
>  		} else
>  			dev_priv->display.update_wm = pineview_update_wm;
> +		dev_priv->display.init_clock_gating = gen3_init_clock_gating;
>  	} else if (IS_G4X(dev)) {
>  		dev_priv->display.update_wm = g4x_update_wm;
>  		dev_priv->display.init_clock_gating = g4x_init_clock_gating;
> 

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center