From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755208Ab1EaOEM (ORCPT ); Tue, 31 May 2011 10:04:12 -0400 Received: from s15228384.onlinehome-server.info ([87.106.30.177]:43689 "EHLO mail.x86-64.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426Ab1EaOEK (ORCPT ); Tue, 31 May 2011 10:04:10 -0400 Date: Tue, 31 May 2011 16:03:59 +0200 From: Borislav Petkov To: Peter Zijlstra , Ben Blum , Stephane Eranian Cc: Ingo Molnar , LKML Subject: perf cgroup per-task attaching Message-ID: <20110531140359.GA13134@aftab> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just FYI: I'm getting kernel/events/core.c:7445: warning: initialization from incompatible pointer type when building -rc1 with CONFIG_CGROUP_PERF enabled. AFAICT, this is due to the fact that f780bdb7c1c73009cb57adcf99ef50027d80bf3c dropped the threadgroup arg from cgroup_subsys->attach in favour of per-thread callbacks. perf_cgroup_attach() actually does reschedule the task context after the cgroup changes so the perf cgroup code would need some non-trivial adjusting to the new APIs. -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632