From: David Miller <davem@davemloft.net>
To: khilman@ti.com
Cc: julia@diku.dk, kernel-janitors@vger.kernel.org, cyril@ti.com,
srk@ti.com, weil@mail.berlios.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/10] drivers/net/davinci_emac.c: add missing clk_put
Date: Wed, 01 Jun 2011 21:20:36 -0700 (PDT) [thread overview]
Message-ID: <20110601.212036.1247786739427089909.davem@davemloft.net> (raw)
In-Reply-To: <1306957764.26236.37.camel@vence>
From: Kevin Hilman <khilman@ti.com>
Date: Wed, 01 Jun 2011 12:49:24 -0700
> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
>> From: Julia Lawall <julia@diku.dk>
>>
>> Go to existing error handling code at the end of the function that calls
>> clk_put.
>>
>> A simplified version of the semantic match that finds this problem is as
>> follows: (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @r exists@
>> expression e1,e2;
>> statement S;
>> @@
>>
>> e1 = clk_get@p1(...);
>> ... when != e1 = e2
>> when != clk_put(e1)
>> when any
>> if (...) { ... when != clk_put(e1)
>> when != if (...) { ... clk_put(e1) ... }
>> * return@p3 ...;
>> } else S
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Acked-by: Kevin Hilman <khilman@ti.com>
Applied, thanks.
prev parent reply other threads:[~2011-06-02 4:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:10 Julia Lawall
2011-06-01 19:49 ` Kevin Hilman
2011-06-02 4:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110601.212036.1247786739427089909.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cyril@ti.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=srk@ti.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®