From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506Ab1FBQxv (ORCPT ); Thu, 2 Jun 2011 12:53:51 -0400 Received: from cantor.suse.de ([195.135.220.2]:40608 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346Ab1FBQxu (ORCPT ); Thu, 2 Jun 2011 12:53:50 -0400 Date: Thu, 2 Jun 2011 18:53:47 +0200 From: Jan Kara To: Akinobu Mita Cc: linux-kernel@vger.kernel.org, Jan Kara , Andrew Morton , Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH v2] ext3: use proper little-endian bitops Message-ID: <20110602165347.GB13668@quack.suse.cz> References: <1306938844-11178-1-git-send-email-akinobu.mita@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1306938844-11178-1-git-send-email-akinobu.mita@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 01-06-11 23:34:04, Akinobu Mita wrote: > ext3_{set,clear}_bit() is defined as __test_and_{set,clear}_bit_le() > for ext3. But all ext3_{set,clear}_bit() calls ignore return values. > So these can be replaced with __{set,clear}_bit_le(). > > This changes ext3_{set,clear}_bit safely, because if someone uses > these macros without noticing the change, new ext3_{set,clear}_bit > don't have return value and causes compiler errors where the return > value is used. > > This also removes unused ext3_find_first_zero_bit(). Thanks. Merged. Honza > > Signed-off-by: Akinobu Mita > Cc: Jan Kara > Cc: Andrew Morton > Cc: Andreas Dilger > Cc: linux-ext4@vger.kernel.org > --- > v2: rewritten to keep ext3_*_bit() macros > > include/linux/ext3_fs.h | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/include/linux/ext3_fs.h b/include/linux/ext3_fs.h > index 5e06acf..50f21ee 100644 > --- a/include/linux/ext3_fs.h > +++ b/include/linux/ext3_fs.h > @@ -418,12 +418,11 @@ struct ext3_inode { > #define EXT2_MOUNT_DATA_FLAGS EXT3_MOUNT_DATA_FLAGS > #endif > > -#define ext3_set_bit __test_and_set_bit_le > +#define ext3_set_bit __set_bit_le > #define ext3_set_bit_atomic ext2_set_bit_atomic > -#define ext3_clear_bit __test_and_clear_bit_le > +#define ext3_clear_bit __clear_bit_le > #define ext3_clear_bit_atomic ext2_clear_bit_atomic > #define ext3_test_bit test_bit_le > -#define ext3_find_first_zero_bit find_first_zero_bit_le > #define ext3_find_next_zero_bit find_next_zero_bit_le > > /* > -- > 1.7.4.4 > -- Jan Kara SUSE Labs, CR