mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, kyungmin.park@samsung.com
Subject: Re: [PATCH] gpio: Samsung: make Kconfig options def_bool
Date: Fri, 3 Jun 2011 12:25:45 -0600	[thread overview]
Message-ID: <20110603182545.GH15616@ponder.secretlab.ca> (raw)
In-Reply-To: <201106021014.59699.hartleys@visionengravers.com>

On Thu, Jun 02, 2011 at 10:14:58AM -0700, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected.  Change the Kconfig symbol to def_bool y
> dependant on the platform.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Patch doesn't apply on mainline.  Linus already fixed up some stuff.

g.

> 
> ---
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>  	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
>  
>  config GPIO_EXYNOS4
> -	bool "Samsung Exynos4 GPIO library support"
> -	default y
> -	depends on ARM && CPU_EXYNOS4210
> -	help
> -	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
> +	def_bool y
> +	depends on CPU_EXYNOS4210
>  
>  config GPIO_PLAT_SAMSUNG
> -	bool "Samsung SoCs GPIO library support"
> -	default y
> -	depends on ARM && SAMSUNG_GPIOLIB_4BIT
> -	help
> -	  Say yes here to support Samsung SoCs GPIO library
> +	def_bool y
> +	depends on SAMSUNG_GPIOLIB_4BIT
>  
>  config GPIO_S5PC100
> -	bool "Samsung S5PC100 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PC100
> -	help
> -	  Say yes here to support Samsung S5PC100 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PC100
>  
>  config GPIO_S5PV210
> -	bool "Samsung S5PV210/S5PC110 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PV210
> -	help
> -	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PV210
>  
>  config GPIO_PL061
>  	bool "PrimeCell PL061 GPIO support"

  reply	other threads:[~2011-06-03 18:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02 17:14 H Hartley Sweeten
2011-06-03 18:25 ` Grant Likely [this message]
2011-06-03 18:32   ` H Hartley Sweeten
2011-06-03 18:35     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603182545.GH15616@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=hartleys@visionengravers.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®