From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756404Ab1FETJY (ORCPT ); Sun, 5 Jun 2011 15:09:24 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:38339 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754591Ab1FETJY (ORCPT ); Sun, 5 Jun 2011 15:09:24 -0400 Date: Sun, 5 Jun 2011 20:11:16 +0100 From: Alan Cox To: Mark Einon Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, o.hartmann@telovital.com Subject: Re: [PATCH 3/5] staging: et131x: et131x_adapter.h checkpatch fixes Message-ID: <20110605201116.4fa28490@lxorguk.ukuu.org.uk> In-Reply-To: <1307295320-31716-4-git-send-email-mark.einon@gmail.com> References: <1307295320-31716-1-git-send-email-mark.einon@gmail.com> <1307295320-31716-4-git-send-email-mark.einon@gmail.com> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.0; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 5 Jun 2011 18:35:18 +0100 Mark Einon wrote: > From: Mark Einon > > Fixes a 'WARNING: do not add new typedefs' and line > 80 chars. Again with the structs the process has been to clean up the field names to Linux style, then rename the struct so we know what is going on Can you lose the _t and change the struct to live as adapter->stats ? Alan