mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolas Kaiser <nikai@nikai.net>
To: Dave Airlie <airlied@linux.ie>
Cc: Greg Dietsche <Gregory.Dietsche@cuw.edu>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] savage: remove unecessary if statement
Date: Mon, 6 Jun 2011 12:53:16 +0200	[thread overview]
Message-ID: <20110606125316.312fad32@absol.kitzblitz> (raw)
In-Reply-To: <1307320332-31429-1-git-send-email-Gregory.Dietsche@cuw.edu>

* Greg Dietsche <Gregory.Dietsche@cuw.edu>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/

> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Reviewed-by: Nicolas Kaiser <nikai@nikai.net>

Best regards,
Nicolas Kaiser
> ---
>  drivers/gpu/drm/savage/savage_bci.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
>  	ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
>  			 _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
>  			 &dev_priv->aperture);
> -	if (ret)
> -		return ret;
> -
>  	return ret;
>  }
>  

  reply	other threads:[~2011-06-06 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06  0:32 Greg Dietsche
2011-06-06 10:53 ` Nicolas Kaiser [this message]
2011-06-13 14:40   ` [PATCH v2] savage: remove unnecessary " Greg Dietsche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110606125316.312fad32@absol.kitzblitz \
    --to=nikai@nikai.net \
    --cc=Gregory.Dietsche@cuw.edu \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®