Re: 3.0.0-rc2 fails to boot on Atom appliance (bisected, drm/i915)

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Mon, 06 Jun 2011 16:59:02 -0700
Ben Greear <greearb@candelatech.com> wrote:

> On 06/06/2011 04:41 PM, Keith Packard wrote:
> > On Mon, 06 Jun 2011 16:26:25 -0700, Ben Greear<greearb@candelatech.com>  wrote:
> >> On 06/06/2011 01:09 PM, Ben Greear wrote:
> >>> Anyone seen something like this?  For what it's worth, it seems
> >>> that -rc1 had the same problem. I'll start bisecting soon if
> >>> the problem isn't already resolved somehow...
> >>
> >> I bisected this problem down to this commit:
> >
> > This should be fixed by this patch:
> >
> > -------------------- drivers/gpu/drm/i915/intel_display.c ---------------------
> > index f553ddf..bb1b59b 100644
> > @@ -7675,6 +7675,7 @@ static void intel_init_display(struct drm_device *dev)
> >   			dev_priv->display.update_wm = NULL;
> >   		} else
> >   			dev_priv->display.update_wm = pineview_update_wm;
> > +		dev_priv->display.init_clock_gating = gen3_init_clock_gating;
> >   	} else if (IS_G4X(dev)) {
> >   		dev_priv->display.update_wm = g4x_update_wm;
> >   		dev_priv->display.init_clock_gating = g4x_init_clock_gating;
> >
> > This hasn't been merged yet, but should be soon.
> 
> I tried adding that, but the problem stays the same.
> 
> Any other patches I should try?

Are you sure you booted the right kernel and that it built & installed
correctly?

You could add an:
  if (dev_priv->display.init_clock_gating)
above the call to display.init_clock_gating in intel_init_clock_gating
to be sure it's the same problem...

-- 
Jesse Barnes, Intel Open Source Technology Center