From: "Ted Ts'o" <tytso@mit.edu>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: unlink(nonexistent): EROFS or ENOENT?
Date: Mon, 6 Jun 2011 15:55:55 -0400 [thread overview]
Message-ID: <20110606195555.GB20818@thunk.org> (raw)
In-Reply-To: <4DED0AB3.6060708@msgid.tls.msk.ru>
On Mon, Jun 06, 2011 at 09:13:23PM +0400, Michael Tokarev wrote:
> Thank you for the answer. I thought noone will reply... ;)
>
> >> Just noticed that at least on ext4, unlinking a
> >> non-existing file from a read-only filesystem
> >> results in EROFS instead of ENOENT. I'd expect
> >> it return ENOENT - it is more logical, at least
> >> in my opinion.
> /* The unlinkat from kernels like linux-2.6.32 reports EROFS even for
> nonexistent files. When the file is indeed missing, map that to ENOENT,
> so that rm -f ignores it, as required. Even without -f, this is useful
> because it makes rm print the more precise diagnostic. */
OK, I see what's going on. This check is in the VFS layer, so it
affects all filesystems; it's not an ext4-specific thing.
Patch coming shortly.
- Ted
next prev parent reply other threads:[~2011-06-06 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 16:08 Michael Tokarev
2011-05-29 16:14 ` Michael Tokarev
2011-06-06 3:39 ` Ted Ts'o
2011-06-06 17:13 ` Michael Tokarev
2011-06-06 17:18 ` Michael Tokarev
2011-06-06 19:55 ` Ted Ts'o [this message]
2011-06-06 20:37 ` [PATCH] vfs: make unlink() return ENOENT in preference to EROFS Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110606195555.GB20818@thunk.org \
--to=tytso@mit.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome