From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960Ab1FHOoc (ORCPT ); Wed, 8 Jun 2011 10:44:32 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:38037 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053Ab1FHOob (ORCPT ); Wed, 8 Jun 2011 10:44:31 -0400 Date: Wed, 8 Jun 2011 08:44:26 -0600 From: Grant Likely To: Tomoya MORINAGA Cc: David Brownell , spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, qi.wang@intel.com, yong.y.wang@intel.com, joel.clark@intel.com, kok.howg.ewe@intel.com, toshiharu-linux@dsn.okisemi.com Subject: Re: [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device ML7213 IOH Message-ID: <20110608144426.GA8499@ponder.secretlab.ca> References: <1307425811-5030-1-git-send-email-tomoya-linux@dsn.okisemi.com> <4DEF3447.6050209@dsn.okisemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DEF3447.6050209@dsn.okisemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2011 at 05:35:19PM +0900, Tomoya MORINAGA wrote: > Hi Grant, > > Why don't you give us your comment/opinion at all for our v4 patch ?? > We have been long waiting since 27-April. Sorry about that Tomoya. I got completely overloaded at the end of April and all of May. I ended up dropping a lot of patches on the floor because of it. I'm not purposefully ignoring you! I'll look at them now. g. > > (2011/06/07 14:50), Tomoya MORINAGA wrote: > > ***Modify Grant's comments. > > - Delete unrelated whitespace > > - Prevent device driver from accessing platform data > > - Add __devinit and __devexit > > - Save pdev->dev to pd_dev->dev.parent > > - Have own suspend/resume processing in platform_driver. > > - Care returned value in pch_spi_init > > - Change unregister order > > > > Support ML7213 device of OKI SEMICONDUCTOR. > > ML7213 is companion chip of Intel Atom E6xx series for IVI(In-Vehicle Infotainment). > > ML7213 is compatible for Intel EG20T PCH. > > > > Signed-off-by: Tomoya MORINAGA > > --- > > drivers/spi/Kconfig | 5 +- > > drivers/spi/spi_topcliff_pch.c | 599 +++++++++++++++++++++------------------- > > 2 files changed, 317 insertions(+), 287 deletions(-) > > > -- > tomoya > OKI SEMICONDUCTOR CO., LTD.