mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Daniel Baluta <dbaluta@ixiacom.com>
Cc: Maxin B John <maxin.john@gmail.com>,
	"nux-doc@vger.kernel.org" <nux-doc@vger.kernel.org>,
	"rdunlap@xenotime.net" <rdunlap@xenotime.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: update kmemleak architecture support info
Date: Fri, 10 Jun 2011 15:55:18 +0100	[thread overview]
Message-ID: <20110610145518.GD18133@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <4DF1C55A.2080803@ixiacom.com>

On Fri, Jun 10, 2011 at 08:18:50AM +0100, Daniel Baluta wrote:
> On 06/10/2011 10:09 AM, Maxin B John wrote:
> > -Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze and tile.
> > +Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze, tile,
> > +s390 and mips.Please check DEBUG_KMEMLEAK dependencies in lib/Kconfig.debug
> > +for supported platforms.
> The point of adding my generic comment was to remove direct
> references to supported platforms.
> 
> In this case your patch should remove the line specifying supported
> platforms (x86, arm, powerpc, etc) and only add the line pointing
> the reader to lib/Kconfig.debug.
> 
> When a new platform will be supported lib/Kconfig.debug will
> be surely modified, and the change will be consistent with
> information in kmemleak.txt.

I think Daniel's suggestion is better, we don't have to worry about
changing the documentation every time we add a new architecture.

In addition to that, I would say "supported architectures" rather than
platforms.

Thanks.

-- 
Catalin


  reply	other threads:[~2011-06-10 14:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10  7:09 Maxin B John
2011-06-10  7:18 ` Daniel Baluta
2011-06-10 14:55   ` Catalin Marinas [this message]
2011-06-10 17:55     ` Randy Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2011-06-10 19:09 Maxin B John
2011-06-10 20:18 ` Randy Dunlap
2011-06-10 21:22   ` Catalin Marinas
2011-06-09 18:59 Maxin B John
2011-06-10  6:46 ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110610145518.GD18133@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=dbaluta@ixiacom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxin.john@gmail.com \
    --cc=nux-doc@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®