mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: jasowang@redhat.com, rusty@rustcorp.com.au,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, yvugenfi@redhat.com,
	kvm@vger.kernel.org, herbert@gondor.hengli.com.au
Subject: Re: [PATCH] virtio_net: introduce VIRTIO_NET_HDR_F_DATA_VALID
Date: Sat, 11 Jun 2011 15:58:02 -0700 (PDT)	[thread overview]
Message-ID: <20110611.155802.495936379311916892.davem@davemloft.net> (raw)
In-Reply-To: <20110610112828.GA21037@redhat.com>

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Fri, 10 Jun 2011 14:28:28 +0300

> On Fri, Jun 10, 2011 at 06:56:17PM +0800, Jason Wang wrote:
>> There's no need for the guest to validate the checksum if it have been
>> validated by host nics. So this patch introduces a new flag -
>> VIRTIO_NET_HDR_F_DATA_VALID which is used to bypass the checksum
>> examing in guest. The backend (tap/macvtap) may set this flag when
>> met skbs with CHECKSUM_UNNECESSARY to save cpu utilization.
>> 
>> No feature negotiation is needed as old driver just ignore this flag.
> 
> This wasn't required by the spec, but maybe it should be.
> 
>> Iperf shows 12%-30% performance improvement for UDP traffic. For TCP,
>> when gro is on no difference as it produces skb with partial
>> checksum. But when gro is disabled, 20% or even higher improvement
>> could be measured by netperf.
>> 
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> 
> 
> Acked-by: Michael S. Tsirkin <mst@redhat.com>

Applied to net-next-2.6

      reply	other threads:[~2011-06-11 22:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-10 10:56 Jason Wang
2011-06-10 11:28 ` Michael S. Tsirkin
2011-06-11 22:58   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110611.155802.495936379311916892.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®