From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752858Ab1FKXF3 (ORCPT ); Sat, 11 Jun 2011 19:05:29 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:50383 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751905Ab1FKXF0 (ORCPT ); Sat, 11 Jun 2011 19:05:26 -0400 Date: Sat, 11 Jun 2011 16:01:19 -0700 (PDT) Message-Id: <20110611.160119.176399204911265689.davem@davemloft.net> To: ralf@linux-mips.org Cc: jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, avorontsov@mvista.com, cmetcalf@tilera.com, ccross@android.com, eric.y.miao@gmail.com, konkers@android.com, gxt@mprc.pku.edu.cn, hpa@zytor.com, kaloz@openwrt.org, mingo@redhat.com, ink@jurassic.park.msu.ru, khc@pm.waw.pl, kernel@wantstofly.org, mattst88@gmail.com, nico@fluxnic.net, olof@lixom.net, lethal@linux-sh.org, rth@twiddle.net, linux@arm.linux.org.uk, tglx@linutronix.de, akpm@linux-foundation.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const. From: David Miller In-Reply-To: <20110610143021.GA26043@linux-mips.org> References: <20110610143021.GA26043@linux-mips.org> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Sat, 11 Jun 2011 16:01:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ralf Baechle Date: Fri, 10 Jun 2011 15:30:21 +0100 > Aside of the usual motivation for constification, this function has a > history of being abused a hook for interrupt and other fixups so I turned > this function const ages ago in the MIPS code but it should be done > treewide. > > Due to function pointer passing in varous places a few other functions > had to be constified as well. > > Signed-off-by: Ralf Baechle Acked-by: David S. Miller