From: Grant Likely <grant.likely@secretlab.ca>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Ryan Mallon <ryan@bluewatersys.com>
Subject: Re: [PATCH] gpio/ep93xx: Add missing EP93XX_GPIO_PHYS_BASE define
Date: Fri, 10 Jun 2011 23:28:14 -0600 [thread overview]
Message-ID: <20110611052814.GA16924@ponder.secretlab.ca> (raw)
In-Reply-To: <201106100908.18678.hartleys@visionengravers.com>
On Fri, Jun 10, 2011 at 09:08:17AM -0700, H Hartley Sweeten wrote:
> The patch to convert of the ep93xx gpio driver to a platform_driver is
> missing the define for the memory resource that is passed to the driver.
>
> This is needed to prevent a build error.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
Applied, thanks.
g.
>
> ---
>
> Grant, can you pick this up in your tree to prevent the build error?
>
> diff --git a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> index 9ac4d10..c4a7b84 100644
> --- a/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> +++ b/arch/arm/mach-ep93xx/include/mach/ep93xx-regs.h
> @@ -98,6 +98,7 @@
>
> #define EP93XX_SECURITY_BASE EP93XX_APB_IOMEM(0x00030000)
>
> +#define EP93XX_GPIO_PHYS_BASE EP93XX_APB_PHYS(0x00040000)
> #define EP93XX_GPIO_BASE EP93XX_APB_IOMEM(0x00040000)
> #define EP93XX_GPIO_REG(x) (EP93XX_GPIO_BASE + (x))
> #define EP93XX_GPIO_F_INT_STATUS EP93XX_GPIO_REG(0x5c)
prev parent reply other threads:[~2011-06-11 5:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 16:08 H Hartley Sweeten
2011-06-11 5:28 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110611052814.GA16924@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®