From: Felipe Balbi <balbi@ti.com>
To: Skacore Systems <skacore.systems@gmail.com>
Cc: linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] s3c2410_udc: udc command always disables pull-up instead of passing the command
Date: Tue, 14 Jun 2011 19:49:03 +0300 [thread overview]
Message-ID: <20110614164900.GR2353@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <BANLkTik+TD1+k1hd-hEteE5OTeDrDAuMZQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
Hi,
On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
> Sorry for the HTML,
> There is a bug in s3c2410_udc driver, which triggers when using custom
> UDC command for USB pull-up.
> As a result driver is always calling user defined UDC command with
> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
> just passing the parameter to the user defined function.
please take a look at Documentation/SubmittingPatches and fix up your
patch so that it can be applied. Also, when sending patches,
scripts/get_maintainer.pl will give you a hint of who you should put on
Cc ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-06-14 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTimU+E8Y0_9+H2nsF6CMg66_TDH0LQ@mail.gmail.com>
[not found] ` <BANLkTimL=+vaa7NB5FW192rZd08Gv-Z-OA@mail.gmail.com>
2011-06-14 14:58 ` Skacore Systems
2011-06-14 16:49 ` Felipe Balbi [this message]
2011-06-15 7:30 ` Skacore Systems
2011-06-15 8:38 ` Felipe Balbi
2011-06-15 8:43 ` Skacore Systems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614164900.GR2353@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=skacore.systems@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®