From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6 of 6] x86, UV: correct UV2 BAU destination timeout
Date: Wed, 15 Jun 2011 09:43:19 +0200 [thread overview]
Message-ID: <20110615074319.GC3538@elte.hu> (raw)
In-Reply-To: <E1QWchi-0004Ng-1i@eag09.americas.sgi.com>
* Cliff Wickman <cpw@sgi.com> wrote:
> From: Cliff Wickman <cpw@sgi.com>
>
> Correct the UV2 broacast assist unit's destination timeout period.
> The period is set in 4 bits of memory-mapped register MISC_CONTROL.
> The left bit toggles base period between 10us and 80us.
> The other 3 bits are the multiplier.
> Decimal 15, hex f, gives the maximum: 7 * 80us
>
> And the activation status register in UV2 should be tested for a destination
> timeout with a 4, not a 2. The values for Active versus Timeout were reversed.
This changelog tells us everything except what a user of this code
would be most interested in: what was the practical effect of the
bug, how badly does the user want the fix?
Thanks,
Ingo
prev parent reply other threads:[~2011-06-15 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 23:07 Cliff Wickman
2011-06-15 7:43 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615074319.GC3538@elte.hu \
--to=mingo@elte.hu \
--cc=cpw@sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®