mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: [PATCH 09/16 v2] tracing, function: Fix trace header to follow context-info option
Date: Wed, 15 Jun 2011 09:48:50 -0400	[thread overview]
Message-ID: <20110615135234.945968095@goodmis.org> (raw)
In-Reply-To: <20110615134841.767565350@goodmis.org>

[-- Attachment #1: 0009-tracing-function-Fix-trace-header-to-follow-context-.patch --]
[-- Type: text/plain, Size: 1391 bytes --]

From: Jiri Olsa <jolsa@redhat.com>

The header display of function tracer does not follow
the context-info option, so field names are displayed even
if this option is off.

Added check for TRACE_ITER_CONTEXT_INFO trace_flags.

With following commands:
	# echo function > ./current_tracer
	# echo 0 > options/context-info
	# cat trace

This is what it looked like before:
# tracer: function
#
#           TASK-PID    CPU#    TIMESTAMP  FUNCTION
#              | |       |          |         |
add_preempt_count <-schedule
rcu_note_context_switch <-schedule
...

This is what it looks like now:
# tracer: function
#
_raw_spin_unlock_irqrestore <-hrtimer_try_to_cancel
...

Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1307113131-10045-4-git-send-email-jolsa@redhat.com
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/trace.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 42fdf3a..cf22b4b 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2053,6 +2053,9 @@ void trace_default_header(struct seq_file *m)
 {
 	struct trace_iterator *iter = m->private;
 
+	if (!(trace_flags & TRACE_ITER_CONTEXT_INFO))
+		return;
+
 	if (iter->iter_flags & TRACE_FILE_LAT_FMT) {
 		/* print nothing if the buffers are empty */
 		if (trace_empty(iter))
-- 
1.7.4.4



  parent reply	other threads:[~2011-06-15 13:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 13:48 [PATCH 00/16 v2] [GIT PULL] tracing: various fixes Steven Rostedt
2011-06-15 13:48 ` [PATCH 01/16 v2] tracing: Schedule a delayed work to call wakeup() Steven Rostedt
2011-06-15 13:48 ` [PATCH 02/16 v2] tracing: Use NUMA allocation for per-cpu ring buffer pages Steven Rostedt
2011-06-15 13:48 ` [PATCH 03/16 v2] tracing: Add a proc file to stop tracing and free buffer Steven Rostedt
2011-06-15 14:25   ` Frederic Weisbecker
2011-06-15 14:43     ` Steven Rostedt
2011-06-15 14:45       ` Frederic Weisbecker
2011-06-15 13:48 ` [PATCH 04/16 v2] tracing: Add disable_on_free option Steven Rostedt
2011-06-15 13:48 ` [PATCH 05/16 v2] ftrace: Fixed an include coding style issue Steven Rostedt
2011-06-15 13:48 ` [PATCH 06/16 v2] async: " Steven Rostedt
2011-06-15 13:48 ` [PATCH 07/16 v2] tracing, function_graph: Remove dependency of abstime and duration Steven Rostedt
2011-06-15 13:48 ` [PATCH 08/16 v2] tracing, function_graph: Merge overhead and duration display Steven Rostedt
2011-06-15 13:48 ` Steven Rostedt [this message]
2011-06-15 13:48 ` [PATCH 10/16 v2] tracing, function_graph: Remove lock-depth from latency trace Steven Rostedt
2011-06-15 13:48 ` [PATCH 11/16 v2] tracing, function_graph: Add context-info support for function_graph Steven Rostedt
2011-06-15 13:48 ` [PATCH 12/16 v2] tracing: Convert to kstrtoul_from_user Steven Rostedt
2011-06-15 13:48 ` [PATCH 13/16 v2] ring-buffer: Set __GFP_NORETRY flag for ring buffer allocating Steven Rostedt
2011-06-15 13:48 ` [PATCH 14/16 v2] x86: Swap save_stack_trace_regs parameters Steven Rostedt
2011-06-15 13:48 ` [PATCH 15/16 v2] stack_trace: Add weak save_stack_trace_regs() Steven Rostedt
2011-06-15 13:48 ` [PATCH 16/16 v2] tracing/kprobes: Fix kprobe-tracer to support stack trace Steven Rostedt
2011-06-16 14:00 ` [PATCH 00/16 v2] [GIT PULL] tracing: various fixes Ingo Molnar
2011-06-28 19:48   ` Steven Rostedt
2011-07-01 12:44     ` Ingo Molnar
2011-07-01 13:11       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615135234.945968095@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®