From: Michal Marek <mmarek@suse.cz>
To: Andy Whitcroft <apw@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] perf: clear out make flags when calling kernel make kernelver
Date: Wed, 15 Jun 2011 22:13:53 +0200 [thread overview]
Message-ID: <20110615201353.GA15999@sepie.suse.cz> (raw)
In-Reply-To: <1308144900-1945-1-git-send-email-apw@canonical.com>
On Wed, Jun 15, 2011 at 02:35:00PM +0100, Andy Whitcroft wrote:
> When generating the perf version from the kernel version using 'make
> kernelver' it is necessary to clear out any MAKEFLAGS otherwise they may
> trigger additional output which pollute the contents.
>
> Signed-off-by: Andy Whitcroft <apw@canonical.com>
> ---
> tools/perf/util/PERF-VERSION-GEN | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/perf/util/PERF-VERSION-GEN b/tools/perf/util/PERF-VERSION-GEN
> index 9c5fb4d..ad73300 100755
> --- a/tools/perf/util/PERF-VERSION-GEN
> +++ b/tools/perf/util/PERF-VERSION-GEN
> @@ -23,7 +23,7 @@ if test -d ../../.git -o -f ../../.git &&
> then
> VN=$(echo "$VN" | sed -e 's/-/./g');
> else
> - VN=$(make -sC ../.. kernelversion)
> + VN=$(MAKEFLAGS= make -sC ../.. kernelversion)
> fi
Thanks, applied to kbuild-2.6.git#rc-fixes.
Michal
prev parent reply other threads:[~2011-06-15 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 13:35 Andy Whitcroft
2011-06-15 20:13 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110615201353.GA15999@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®