From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722Ab1FQC6g (ORCPT ); Thu, 16 Jun 2011 22:58:36 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:46226 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813Ab1FQC6f (ORCPT ); Thu, 16 Jun 2011 22:58:35 -0400 Date: Thu, 16 Jun 2011 22:58:25 -0400 (EDT) Message-Id: <20110616.225825.127982592225091945.davem@davemloft.net> To: jasowang@redhat.com Cc: arnd@arndb.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue() From: David Miller In-Reply-To: <1307934919-4189-1-git-send-email-jasowang@redhat.com> References: <1307934919-4189-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Thu, 16 Jun 2011 19:58:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Mon, 13 Jun 2011 11:15:19 +0800 > The calling of sock_put() should be delayed after synchronize_rcu(), > otherwise inconsist data may be seen during packets transmitting. > > Signed-off-by: Jason Wang You're leaking sockets now. This function has to release the socket twice if there is a non-NULL vlan assigned to the queue. Now you're only doing it once in that situation. Which probably fixes your crash, but adds a socket leak.