From: Pete Zaitcev <zaitcev@redhat.com>
To: Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
christian.dietrich@informatik.uni-erlangen.de
Subject: Re: [PATCH 11/11] usb/class: use printk_ratelimited() instead of printk_ratelimit()
Date: Thu, 16 Jun 2011 09:36:10 -0600 [thread overview]
Message-ID: <20110616093610.0415834c@lembas.zaitcev.lan> (raw)
In-Reply-To: <3842dc0135657cd0b1ba08436a1c501c19ad0116.1308142053.git.manuel.f.zerpies@ww.stud.uni-erlangen.de>
On Thu, 16 Jun 2011 14:15:54 +0200
Manuel Zerpies <manuel.f.zerpies@ww.stud.uni-erlangen.de> wrote:
> +++ b/drivers/usb/class/usblp.c
> @@ -348,8 +349,7 @@ static int usblp_check_status(struct usblp *usblp, int err)
> mutex_lock(&usblp->mut);
> if ((error = usblp_read_status(usblp, usblp->statusbuf)) < 0) {
> mutex_unlock(&usblp->mut);
> - if (printk_ratelimit())
> - printk(KERN_ERR
> + printk_ratelimited(KERN_ERR
> "usblp%d: error %d reading printer status\n",
I wish you went a step further and placed the state into usblp,
but it works for now, ACK. I should've done it myself, really.
-- Pete
prev parent reply other threads:[~2011-06-16 15:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1308142053.git.manuel.f.zerpies@ww.stud.uni-erlangen.de>
2011-06-16 12:06 ` [PATCH 01/11] drivers/ide: " Manuel Zerpies
2011-06-16 14:19 ` Borislav Petkov
2011-06-20 8:17 ` Manuel Zerpies
2011-06-20 8:22 ` Sergei Shtylyov
2011-06-16 14:32 ` Sergei Shtylyov
2011-06-16 12:07 ` [PATCH 02/11] drivers/tty: " Manuel Zerpies
2011-06-16 12:08 ` [PATCH 03/11] net/can: " Manuel Zerpies
2011-06-17 4:03 ` David Miller
2011-06-16 12:09 ` [PATCH 04/11] net/rds: use prink_ratelimited() " Manuel Zerpies
2011-06-17 4:03 ` David Miller
2011-06-16 12:10 ` [PATCH 05/11] RDMA/hw/cxgb4: use printk_ratelimited() " Manuel Zerpies
2011-07-19 4:19 ` Roland Dreier
2011-06-16 12:12 ` [PATCH 06/11] drivers/net: " Manuel Zerpies
2011-06-16 16:43 ` Joe Perches
2011-06-16 12:12 ` [PATCH 07/11] drivers/usb/atm: " Manuel Zerpies
2011-06-16 14:37 ` Sergei Shtylyov
2011-06-16 12:13 ` [PATCH 08/11] [SCSI] tcm_fc: " Manuel Zerpies
2011-06-16 12:14 ` [PATCH 09/11] xen/xenbus: " Manuel Zerpies
2011-06-16 21:00 ` Jeremy Fitzhardinge
2011-06-16 23:44 ` Joe Perches
2011-06-16 12:15 ` [PATCH 10/11] wusb: " Manuel Zerpies
2011-06-16 14:34 ` Sergei Shtylyov
2011-06-16 12:15 ` [PATCH 11/11] usb/class: " Manuel Zerpies
2011-06-16 15:36 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616093610.0415834c@lembas.zaitcev.lan \
--to=zaitcev@redhat.com \
--cc=christian.dietrich@informatik.uni-erlangen.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuel.f.zerpies@ww.stud.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®