From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932943Ab1FQT2Z (ORCPT ); Fri, 17 Jun 2011 15:28:25 -0400 Received: from shards.monkeyblade.net ([198.137.202.13]:47527 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932429Ab1FQT2Y (ORCPT ); Fri, 17 Jun 2011 15:28:24 -0400 Date: Fri, 17 Jun 2011 15:28:05 -0400 (EDT) Message-Id: <20110617.152805.824692696209804231.davem@davemloft.net> To: shved@ispras.ru Cc: kevin.curtis@farsite.co.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@ispras.ru Subject: Re: [PATCH] farsync: add module_put to error path in fst_open() From: David Miller In-Reply-To: <1308327913-23220-1-git-send-email-shved@ispras.ru> References: <1308327913-23220-1-git-send-email-shved@ispras.ru> X-Mailer: Mew version 6.3 on Emacs 23.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (shards.monkeyblade.net [198.137.202.13]); Fri, 17 Jun 2011 12:28:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Shved Date: Fri, 17 Jun 2011 20:25:10 +0400 > The fst_open() function, after a successful try_module_get() may return > an error code if hdlc_open() returns it. However, it does not put the > module on this error path. > > This patch adds the necessary module_put() call. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Pavel Shved Applied.