mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Patrice Vilchez <patrice.vilchez@atmel.com>,
	Alan Cox <alan@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] atmel_serial: keep the platform_device unchanged
Date: Fri, 17 Jun 2011 05:06:12 +0200	[thread overview]
Message-ID: <20110617030612.GK4581@game.jcrosoft.org> (raw)
In-Reply-To: <1307541740.10626.15.camel@hcegtvedt.norway.atmel.com>

On 16:02 Wed 08 Jun     , Hans-Christian Egtvedt wrote:
> On Wed, 2011-06-08 at 15:47 +0200, Jean-Christophe PLAGNIOL-VILLARD
> wrote:
> > On 10:45 Wed 08 Jun     , Hans-Christian Egtvedt wrote:
> > > On Wed, 2011-04-13 at 21:47 +0200, Jean-Christophe PLAGNIOL-VILLARD
> > > wrote:
> 
> <snipp>
> 
> > > > diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
> > > > index bfc9d07..aa677e2 100644
> > > > --- a/arch/avr32/mach-at32ap/at32ap700x.c
> > > > +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> > > > @@ -1014,6 +1014,7 @@ static struct platform_device *__initdata at32_usarts[4];
> > > >  void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags)
> > > >  {
> > > >  	struct platform_device *pdev;
> > > > +	struct atmel_uart_data *pdata;
> > > >  
> > > >  	switch (hw_id) {
> > > >  	case 0:
> > > > @@ -1042,7 +1043,8 @@ void __init at32_map_usart(unsigned int hw_id, unsigned int line, int flags)
> > > >  		data->regs = (void __iomem *)pdev->resource[0].start;
> > > >  	}
> > > >  
> > > > -	pdev->id = line;
> > > 
> > > AVR32 needs this to be present to work independent of which USART
> > > peripheral the user chooses to use for console.
> > > 
> > > > +	pdata = pdev->dev.platform_data;
> > > > +	pdata->num = portnr;
> > here supposed to be
> > 	pdata->num = line;
> 
> I know, but that doesn't fix the problem about not able to find a
> console, the platform data id must also be 0 (if console is on ttyS0)
> AFAICT.
will test this weekend on avr32

Best Regards,
J.

  reply	other threads:[~2011-06-17  7:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 19:47 Jean-Christophe PLAGNIOL-VILLARD
2011-04-13 21:58 ` Alan Cox
2011-04-15 19:02   ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-08  8:45 ` Hans-Christian Egtvedt
2011-06-08 13:47   ` Jean-Christophe PLAGNIOL-VILLARD
2011-06-08 14:02     ` Hans-Christian Egtvedt
2011-06-17  3:06       ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-06-21 14:28       ` Jean-Christophe PLAGNIOL-VILLARD
     [not found]       ` <1308666679-12111-1-git-send-email-plagnioj@jcrosoft.com>
     [not found]         ` <loom.20110808T170457-559@post.gmane.org>
     [not found]           ` <4E411CEF.10004@ru.mvista.com>
2011-08-09 14:16             ` [PATCH] atmel_serial: fix atmel_default_console_device Voss, Nikolaus
     [not found]             ` <EF2E73589CA71846A15D0B2CDF79505D087B0192D6@wm021.weinmann.com>
     [not found]               ` <4E4267BF.5040609@ru.mvista.com>
2011-08-10 12:02                 ` [PATCH v2] " Voss, Nikolaus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110617030612.GK4581@game.jcrosoft.org \
    --to=plagnioj@jcrosoft.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=hans-christian.egtvedt@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=patrice.vilchez@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome